Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configures report-only CSP for lab #2388

Merged
merged 19 commits into from
Jul 9, 2024
Merged

chore: configures report-only CSP for lab #2388

merged 19 commits into from
Jul 9, 2024

Conversation

bkrem
Copy link
Member

@bkrem bkrem commented Jun 10, 2024

Breaking Changes

None

Changes

Related

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 9, 2024 9:20am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 9, 2024 9:20am

@bkrem
Copy link
Member Author

bkrem commented Jun 11, 2024

@chris13524 thanks for fixing up a bunch 🙏 found some more missing for img-src from playing around with Swaps beta and ENS profile resolution.

apps/laboratory/next.config.js Outdated Show resolved Hide resolved
apps/laboratory/next.config.js Outdated Show resolved Hide resolved
@chris13524
Copy link
Member

Can we merge this?

style-src 'self' 'unsafe-inline' https://fonts.googleapis.com;
img-src 'self' data: blob: https://walletconnect.org https://walletconnect.com https://secure.walletconnect.com https://secure.walletconnect.org https://tokens-data.1inch.io https://tokens.1inch.io https://ipfs.io https://lab.web3modal.com;
font-src 'self' https://fonts.gstatic.com;
connect-src 'self' https://rpc.walletconnect.com https://rpc.walletconnect.org https://explorer.walletconnect.com https://explorer.walletconnect.org https://relay.walletconnect.com https://relay.walletconnect.org wss://relay.walletconnect.com wss://relay.walletconnect.org https://pulse.walletconnect.com https://pulse.walletconnect.org https://api.web3modal.com https://api.web3modal.org wss://www.walletlink.org https://o1095249.ingest.sentry.io https://arb1.arbitrum.io;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is arbitrum here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chris13524 added it, but I think it's because of default RPC endpoints used via https://github.com/wevm/viem/blob/main/src/chains/definitions/arbitrum.ts

@bkrem bkrem marked this pull request as ready for review July 8, 2024 10:45
@bkrem bkrem changed the title chore: dogfood CSP in report-only mode chore: configures report-only CSP for lab Jul 8, 2024
@bkrem bkrem merged commit d82887c into main Jul 9, 2024
9 checks passed
@bkrem bkrem deleted the chore/csp-dogfooding branch July 9, 2024 09:39
This was referenced Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants