Feat/e2e pipeline #1238
Feat/e2e pipeline #1238
Conversation
…s quicker in the future
…d more explorer page testing, started creating fixtures for cleanup, added skeleton for injected wallets
…nd creating playwright fixtures. This will allow for cleaner tests
… easier to update tests in the futue as the ui changes, ec/ V2 -> v3
…rent ways to write the ui validators
…e them. Cleaned up vars
…or functions, fixed gitignore, added a seperate script for playwright for future modiciation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
e79f92a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5099b63.web3modal-dev.pages.dev |
| Branch Preview URL: | https://feat-e2e-pipeline.web3modal-dev.pages.dev |
| @@ -0,0 +1,51 @@ | |||
| name: Pull request E2E tests | |||
|
|
|||
There was a problem hiding this comment.
why are you ignoring my previous PR feedback here?
Please either say you disagree with the feedback or agree with it but don't ignore it.
There was a problem hiding this comment.
I did not ignore your pervious feedback
This draft pr was never meant to be reviewed
I was using this PR to test solutions to an issue I linked in our slack
I agree with the changes you suggested and they will be there in the final version
.github/workflows/pr_e2e_tests.yml
Outdated
| on: | ||
| pull_request: | ||
| branches: | ||
| - V2 |
There was a problem hiding this comment.
feels like a regression to the previous iteration where you also ran upon push
There was a problem hiding this comment.
The previous iteration did not exist, I never wrote a previous iteration
That was auto generated by playwright
I later removed it to try and fix the confusion
.github/workflows/pr_e2e_tests.yml
Outdated
| @@ -0,0 +1,51 @@ | |||
| name: Pull request E2E tests | |||
There was a problem hiding this comment.
Any reason you're narrowing it down to PRs now?
There was a problem hiding this comment.
Discussed with JS team yesterday, was told to run at the same time as other PR checks
WIP
Changes