Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project to tracked time entries overview #161

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

CuddlyBunion341
Copy link
Contributor

@simon-isler simon-isler self-requested a review January 14, 2025 15:24
Copy link
Member

@simon-isler simon-isler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR! 🙌🏼 Just a small comment/suggestion

(please try to specify a ticket: I went with https://redmine.renuo.ch/issues/19656)

app/helpers/timer_sessions_helper.rb Outdated Show resolved Hide resolved
app/helpers/timer_sessions_helper.rb Outdated Show resolved Hide resolved
test/unit/timer_sessions_helper_test.rb Outdated Show resolved Hide resolved
@CuddlyBunion341 CuddlyBunion341 force-pushed the feature/tracky-project branch 2 times, most recently from 615cb73 to b584c3f Compare January 14, 2025 16:09
Copy link
Member

@simon-isler simon-isler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/helpers/timer_sessions_helper.rb Show resolved Hide resolved
@CuddlyBunion341 CuddlyBunion341 merged commit b5c4bf5 into main Jan 15, 2025
1 check passed
@CuddlyBunion341 CuddlyBunion341 deleted the feature/tracky-project branch January 15, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants