Fix timer stop #155
Merged
Fix timer stop #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CuddlyBunion341
commented
Nov 4, 2024
| return render_js(:update, :unprocessable_entity) unless @current_timer_session.update(timer_params) | ||
| updated_params = timer_params | ||
|
|
||
| updated_params[:timer_end] = user_time_zone.now.asctime if updated_params[:timer_end].blank? |
There was a problem hiding this comment.
Should be moved into the model perhaps?
There was a problem hiding this comment.
This is not nicely possible, because a timer session without end time is valid, right?
schmijos
approved these changes
Nov 5, 2024
| destroy : Destroy Session | ||
| destroy --> Cancel : Cancel Timer | ||
| Cancel --> [*] : Return Cancel | ||
| ``` |
There was a problem hiding this comment.
Terminology doesn't seem correct yet on a first glance. Let's bring it on an correct it in a separate PR. I find the graph useful. Let's discuss this in person.
| return render_js(:update, :unprocessable_entity) unless @current_timer_session.update(timer_params) | ||
| updated_params = timer_params | ||
|
|
||
| updated_params[:timer_end] = user_time_zone.now.asctime if updated_params[:timer_end].blank? |
There was a problem hiding this comment.
This is not nicely possible, because a timer session without end time is valid, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the tracky issue where stopping a timer session with empty end_time would not finish the session.
Todo