feat(rawExec): add custom data listeners support #34066
Open
+73
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Feb 6, 2025
viceice
reviewed
Feb 6, 2025
+ make outputListeners part of opts
rarkins
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rawExecis used as a library function in multiple places by us. This PR enables registering custom data listeners for the child process's stdout and stderr streams, allowing real-time processing in the parent process.Note, This change is not suppose to affect the cli in anyway.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: