Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitea): sort commit status by id #33622

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 15, 2025

Changes

Sort commit status by id when computing worst status. They can have same time stamp.
Also return filtered status list, otherwise we can find wrong status.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor January 15, 2025 08:47
@viceice viceice changed the title Fix/gitea/order status by fix(gitea): sort commit status by id Jan 15, 2025
@viceice viceice added the platform:gitea Gitea or Forgejo platforms label Jan 15, 2025
@viceice viceice added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit bddef47 Jan 15, 2025
40 checks passed
@viceice viceice deleted the fix/gitea/order-status-by-id branch January 15, 2025 09:21
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.107.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gitea Gitea or Forgejo platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitea status checks: sort/filter based on id not date
3 participants