feat(gitlabci): Use schema for dep extraction #33586
Open
+171
−439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Jan 16, 2025
| const docs = parseYaml<GitlabPipeline>(content, { | ||
| uniqueKeys: false, | ||
| }); | ||
| const docs = parseYaml(content, { uniqueKeys: false }); |
There was a problem hiding this comment.
why not using yaml schema helper?
There was a problem hiding this comment.
Because it doesn't use uniqueKeys option
There was a problem hiding this comment.
ok, we probably should create a new helper for it? 🙃
why not passing the schema as customSchema via options?
viceice
reviewed
Jan 17, 2025
| const docs = parseYaml<GitlabPipeline>(content, { | ||
| uniqueKeys: false, | ||
| }); | ||
| const docs = parseYaml(content, { uniqueKeys: false }); |
There was a problem hiding this comment.
ok, we probably should create a new helper for it? 🙃
why not passing the schema as customSchema via options?
Comment on lines
+21
to
+22
| const docs = parseYaml(content, { uniqueKeys: false }); | ||
| for (const dep of GitlabDocumentArray.parse(docs)) { |
There was a problem hiding this comment.
pass schema via customSchema option to parseYaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: