Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): replace INFO with DEBUG logs #33478

Merged
merged 5 commits into from
Jan 16, 2025
Merged

feat(logger): replace INFO with DEBUG logs #33478

merged 5 commits into from
Jan 16, 2025

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • remove templating from INFO log messages

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice changed the title refactor(logger): remove templating from INFO log messages feat(logger): remove templating from INFO log messages Jan 8, 2025
rarkins
rarkins requested changes Jan 9, 2025
View reviewed changes
lib/config-validator.ts Outdated Show resolved Hide resolved
lib/modules/datasource/galaxy/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/git-submodules/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/update/locked-dependency/package-lock/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/schema.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/vulnerabilities.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/index.ts Outdated Show resolved Hide resolved
tools/docs/index.ts Outdated Show resolved Hide resolved
rarkins
rarkins requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I changed my mind of something. Because Dry run logs are intended to be human-readable, it's preferable to revert such changes here and keep them with string templating. i.e. remove all changes here with DRY-RUN: and only keep the rest

@RahulGautamSingh RahulGautamSingh changed the title feat(logger): remove templating from INFO log messages feat(logger): replace INFO with DEBUG logs Jan 12, 2025
@rarkins rarkins added this pull request to the merge queue Jan 16, 2025
Merged via the queue into renovatebot:main with commit b3bd91b Jan 16, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.109.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulGautamSingh @renovate-release @viceice @rarkins