feat(automerge): merge failure comment #33337
Open
+90
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
changed the title
rarkins
requested changes
Dec 30, 2024
| description: | ||
| 'If an error occurs while automerging, a comment will be created to signal the user. Only used if `automergeFailureComment=on-error`.', | ||
| type: 'string', | ||
| default: 'never', |
| @@ -34,6 +34,7 @@ export interface RenovateSharedConfig { | |||
| addLabels?: string[]; | |||
| autoReplaceGlobalMatch?: boolean; | |||
| automerge?: boolean; | |||
| autoMergeFailureComment?: string; | |||
| @@ -1694,13 +1694,21 @@ async function tryPrAutomerge( | |||
| { prNumber, errors: res.errors }, | |||
| 'GitHub-native automerge: fail', | |||
| ); | |||
| if (platformPrOptions.automergeFailureComment === 'on-error') { | |||
There was a problem hiding this comment.
Wrong file for implementation. This only works for GitHub, and even then only for GitHub- active automerge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR intends to implement a PR Comment in case automerge fails, letting the users know that the automerge has failed and that they need to attend to this issue.
Context
This PR is based off of issue 31869 "Add PR comment if automerge attempt fails".
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: