Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mix): use real packages and versions #33307

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

sheerlox
Copy link
Contributor

@sheerlox sheerlox commented Dec 27, 2024

Changes

Updated the mix.exs and mix.lock files to be closer to reality by using actual packages and versions.

No change in behavior.

Context

This makes using mix deps.get possible (note: because they are organization packages, it's still necessary to comment the private secret and another_secret deps, and add back their rows in mix.lock afterward).

This has two benefits:

  • gets the fixture closer to a real-world example, since it's now processable by mix;
  • eases adding dependencies for developers working on the manager, leaving less room for mistakes and further solidifying the previous point.

As to why: I'm working on adding depType support to this manager because it being missing has been the biggest pain in using Renovate in my Elixir projects. Needed to add a few deps for the tests, and found the situation of those two files. Decided that was a good time investment before going through the depType thing.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@sheerlox sheerlox mentioned this pull request Dec 27, 2024
6 tasks
@viceice viceice changed the title chore(mix): use real packages and versions test(mix): use real packages and versions Dec 27, 2024
@viceice viceice enabled auto-merge December 27, 2024 22:02
@viceice viceice added this pull request to the merge queue Dec 27, 2024
Merged via the queue into renovatebot:main with commit a9804b8 Dec 27, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.83.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sheerlox sheerlox deleted the chore/manager-mix-use-real-deps branch December 28, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants