-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(presets): include Astro adapters in astro monorepo #33299
base: main
Are you sure you want to change the base?
Conversation
Do they have the same versions as the main Astro monorepo? |
No, the various Why do you ask? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are they published with same versions? if not then this PR will make PRs immortal which we don't like
Monorepo rules are form packages which must be upgraded together or either PR will break if they are separate PRs |
🤔 Interesting. I don't quite understand the definition here. It seems quite fuzzy to me. Is there a documented definition or philosophy somewhere? I see dozens of currently defined monorepo groups here that contain packages that can be upgraded independently, based on most reasonable definitions in my head. Is the intent for the packages in a monorepo group perhaps one of the following?
It sounds like you're talking about either definition 1 or 2, but I can't think of any packages that would meet this definition. All the packages I'm familiar with that are currently in the monorepo groups list would meet (if I'm not mistaken) definition 3 or 4. These seem like fairly reasonable definitions to me at first glance. I think I'm leaning toward definition 5. When I try to think through all the variations out there (collections of unrelated utils like Happy to move this into an issue or discussion if this is an open question! |
Changes
This adds the missing Astro adapters monorepo packages to the
astro
group.Context
The
astro
group only include the core Astro monorepo. It is missing the Astro adapters monorepo, which includes packages like@astrojs/node
,@astrojs/cloudflare
, etc. These should be grouped together with Astro core dependencies.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: