feat(datasource/unity3d): Use Unity Releases API #33240
Conversation
|
@viceice apparently there is nothing pending, can you merge now? Thanks! |
Head branch was pushed to by a user without write access
|
Also, you can remove the |
| httpMock.scope(uri.origin).get(uri.pathname).reply(200, content); | ||
| httpMock | ||
| .scope(uri.origin) | ||
| .get(uri.pathname + uri.search) |
There was a problem hiding this comment.
use string template instead of + concat
| ].map((fixture) => [fixture, Fixtures.get(fixture + '.xml')]), | ||
| [...Object.keys(Unity3dDatasource.streams)].map((fixture) => [ | ||
| fixture, | ||
| Fixtures.get(fixture + '.json'), |
| ); | ||
|
|
||
| if (legacyKey) { | ||
| if (legacyKey === 'stable') { |
There was a problem hiding this comment.
so stable and lts are effective the same stream?
There was a problem hiding this comment.
If you notice, the “stable” url of the old API points to: https://unity.com/releases/editor/releases.xml
And it redirects to the “lts” url of the old API.
| }; | ||
|
|
||
| response.body.results.forEach((release) => { |
| const UnityRelease = z.object({ | ||
| version: z.string(), | ||
| releaseDate: z.string(), | ||
| releaseNotes: UnityReleaseNote, |
There was a problem hiding this comment.
are you sure this object always exists for all packages / streams?
There was a problem hiding this comment.
I followed the instructions in the official API documentation: https://services.docs.unity.com/release/v1/#tag/Release/operation/getUnityReleases
| @@ -6,7 +6,7 @@ import type { VersioningApi } from '../types'; | |||
| export const id = 'unity3d'; | |||
| export const displayName = 'Unity3D'; | |||
| export const urls = [ | |||
| 'https://docs.unity3d.com/Manual/ScriptCompilationAssemblyDefinitionFiles.html#version-define-expressions', | |||
| 'https://docs.unity3d.com/Manual/assembly-definition-includes.html', | |||
There was a problem hiding this comment.
if you move it to a separate docs PR then it'll merged faster
Co-authored-by: Michael Kriese <[email protected]>
|
All comments answered and all the changes you requested are done @viceice |
Changes
The API has been changed to use the new Unity Releases API instead of the "old RSS system".
The new API is richer in metadata, allows more granularity by having queries (number of results, stream, os, architecture, version, ...). Example: https://services.api.unity.com/unity/editor/release/v1/releases?stream=LTS&platform=WINDOWS&architecture=X86_64
I have removed many tests that no longer make sense and were there before because of the inconsistencies of the RSS system. This new API has filters and these inconsistencies no longer occur.
I have also aligned the Unity terminology of streams (lts, tech, alpha, beta).
Context
Unity Releases API: https://services.docs.unity.com/release/v1/#tag/Release/operation/getUnityReleases
Example call: https://services.api.unity.com/unity/editor/release/v1/releases?stream=LTS
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: