fix(datasource/gitlab-packages): prefer checking for conan_package_name if it exists #33099
+66
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
approved these changes
Dec 14, 2024
auto-merge was automatically disabled
December 14, 2024 12:30
Head branch was pushed to by a user without write access
FFace32
commented
Dec 14, 2024
rarkins
previously approved these changes
Dec 17, 2024
|
Should I update the It seems like that's the reason the pipeline fails. |
Sorry, didn't see the thumbs up until now. |
|
Is there something I can do about the |
viceice
reviewed
Jan 4, 2025
Comment on lines
+88
to
+89
| expect(res).toMatchSnapshot(); | ||
| expect(res?.releases).toHaveLength(3); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checks if
conan_package_nameexists and matches the filtered package name for the gitlab-packages datasource.Context
When querying for uploaded Conan packages on GitLab, the
namevalue contains the version and the channel as well, and this doesn't pass the filter inlib/modules/datasource/gitlab-packages/index.ts.conan_package_name, if it exists, contains only the package name.This can also be seen in the GitLab documentation as an example here: https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/api/packages.md?plain=1#L69-70
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: