Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets/packages): include @types/react-dom in react preset #32995

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Dec 9, 2024

Changes

Context

The packages:react preset does not currently match the @types/react-dom package
secustor/backstage-plugins#499

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Dec 9, 2024

Do the other packages in there already have synchronized versioning? Adding an unsynchronized package can make PRs immortal

@secustor
Copy link
Collaborator Author

secustor commented Dec 9, 2024

The preset would already match packages like react-router-dom, which are out of sync with react itself.
Maybe this is instead a regression from the string pattern matching migration.
In that case we should replace react**

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, didn't found a false positive match on npmjs for react** on first 12 pages.

@rarkins rarkins added this pull request to the merge queue Dec 10, 2024
Merged via the queue into renovatebot:main with commit 318f97f Dec 10, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.61.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants