Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/flux): support chartRef in HelmRelease resources #31962

Open
wants to merge 196 commits into
base: main
Choose a base branch
from
Open

feat(manager/flux): support chartRef in HelmRelease resources #31962

wants to merge 196 commits into from
+328 −17

Conversation

ssams
Copy link
Contributor

@ssams ssams commented Oct 15, 2024 •
edited by viceice
Loading

Changes

Adds support for chartRef fields within HelmRelease resources in the flux manager, as described in #31945.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice reviewed Oct 16, 2024
View reviewed changes
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
@ssams ssams requested a review from viceice October 16, 2024 07:39
viceice
viceice reviewed Nov 5, 2024
View reviewed changes
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/common.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.spec.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Nov 5, 2024

conflicted

@ssams ssams requested a review from viceice November 14, 2024 07:54
viceice
viceice requested changes Nov 18, 2024
View reviewed changes
lib/modules/manager/flux/common.ts Outdated Show resolved Hide resolved
renovate bot and others added 12 commits December 2, 2024 12:13
@renovate @ssams
fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.7.4 (…
952ab86 
…renovatebot#32532)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@viceice @ssams
feat(manager/cargo): support reading package version from workspace (…
8703a11 
…local only) (renovatebot#32533)
@renovate @viceice @ssams
build(deps): update dependency openpgp to v6 (renovatebot#32479)
9a1431c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Kriese <[email protected]>
@renovate @ssams
build(deps): update opentelemetry-js monorepo to v0.54.2 (renovatebot…
2c2fc61 
…#32538)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jamietanna @ssams
docs(gradle): correct requirements to process verification-metadata (r…
be8deab 
…enovatebot#32534)
@renovate @ssams
chore(deps): update github/codeql-action action to v3.27.4 (renovateb…
e86a491 
…ot#32541)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@HonkingGoose @rarkins @ssams
docs: release notes for Renovate v39 (renovatebot#32504)
a4c5c3d 
Co-authored-by: Rhys Arkins <[email protected]>
@renovate @ssams
fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.7.5 (…
4a59916 
…renovatebot#32548)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ssams
chore(deps): update slackapi/slack-github-action action to v1.27.1 (r…
16e70a8 
…enovatebot#32554)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ssams
chore(deps): update python:3.13 docker digest to bc78d3c (renovatebot…
e77948d 
…#32553)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ssams
fix(deps): update ghcr.io/renovatebot/base-image docker tag to v9.7.6 (…
054f0a3 
…renovatebot#32557)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@viceice @ssams
feat(datasource/go): support gitea tags (renovatebot#32555)
e1993a1
risu729 and others added 9 commits December 2, 2024 12:13
@risu729 @viceice @ssams
docs(managers): add missing url and displayName (renovatebot#32621)
a797a72 
Co-authored-by: Michael Kriese <[email protected]>
@renovate @ssams
fix(deps): update dependency mkdocs-material to v9.5.47 (renovatebot#…
d092f92 
…32831)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ssams
chore(deps): update dependency type-fest to v4.28.0 (renovatebot#32832)
4c1bd9a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ssams
chore(deps): update containerbase/internal-tools action to v3.5.4 (re…
ea419c3 
…novatebot#32837)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @ssams
docs: update references to renovate/renovate (renovatebot#32838)
e2729e3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@ForNeVeR @ssams
feat(lib/data): add Funogram monorepo (renovatebot#32835)
721ae18
@ssams
feat(manager/flux): manage HelmChart resource
548ff3e
@ssams
Merge remote-tracking branch 'upstream/main' into feat/flux-chartref
aaf1af2
@ssams
Merge remote-tracking branch 'upstream/main' into feat/flux-chartref
d5f35b4
@ssams
Copy link
Contributor Author

ssams commented Dec 2, 2024

unfortunately a lot of commits were introduced accidentally on this branch when merging with main somehow, but as far as I understand that shouldn't be a problem as you'll squash this anyway when merging? at least wanted to avoid force committing to remove them for now as described in the contrib guide, let me know if you need any changes to clean that up. the diff itself is clean though.

@ssams ssams requested a review from viceice December 2, 2024 11:21
viceice
viceice reviewed Dec 12, 2024
View reviewed changes
lib/modules/manager/flux/common.ts Outdated Show resolved Hide resolved
lib/modules/manager/flux/extract.ts Outdated Show resolved Hide resolved
@ssams ssams requested a review from viceice December 20, 2024 08:04
@rarkins rarkins marked this pull request as draft January 7, 2025 10:25
@ssams ssams mentioned this pull request Jan 8, 2025
Merged
6 tasks
@ssams ssams marked this pull request as ready for review January 8, 2025 15:38
@ssams ssams requested a review from rarkins January 15, 2025 09:48
viceice
viceice reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry conflicted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.