fix(gitlab): remove approval rules only if automerging #31720
Closed
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #31354 Move the logic for ignoring approvals from the `tryPrAutomerge` function into the `createPr` function. * Update the `createPr` function to call `ignoreApprovals` only for merge requests with `automerge` enabled. * Add tests in `lib/config/migrate-validate.spec.ts` to verify that approval rules are not removed for merge requests without `automerge` enabled. * Add tests in `lib/config/presets/gitlab/index.spec.ts` to verify that approval rules are removed for merge requests with `automerge` enabled and not removed for merge requests without `automerge` enabled. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/renovatebot/renovate/issues/31354?shareId=XXXX-XXXX-XXXX-XXXX).
rarkins
commented
Oct 1, 2024
rarkins
commented
Oct 1, 2024
rarkins
deleted the
rarkins/fix/31354-gitlab-approval-rules-no-automerge
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31354
Move the logic for ignoring approvals from the
tryPrAutomergefunction into thecreatePrfunction.createPrfunction to callignoreApprovalsonly for merge requests withautomergeenabled.lib/config/migrate-validate.spec.tsto verify that approval rules are not removed for merge requests withoutautomergeenabled.lib/config/presets/gitlab/index.spec.tsto verify that approval rules are removed for merge requests withautomergeenabled and not removed for merge requests withoutautomergeenabled.For more details, open the Copilot Workspace session.