-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(datasource/deb): All items in the urls array are wrapped between []() character. #31161
base: main
Are you sure you want to change the base?
Conversation
… []() characters.
Does this already work if merged, or needs some changes to our docs generation first? |
Fails if merged
The
This is the code that generates the Lines 51 to 58 in 9b64288
I'll let you programmers figure out what the proper fix is. 😉 ScopeI guess this PR only tries to fix the bad links in the Debian datasource file, but there are still bare links in other files, for example: renovate/lib/modules/versioning/composer/index.ts Lines 12 to 17 in 9b64288
Test that finds bad linksI would also like to see a test to check for bad links in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment in the PR for more info, to summarize:
- The docs build should pass
- The docs should have a list with human-readable links
Changes
Context
index.ts
files in themodules/versioning/*/
pattern with good links #30312Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: