Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(npm): log hostRules npmrc logic #30274

Merged
merged 5 commits into from
Sep 22, 2024
Merged

chore(npm): log hostRules npmrc logic #30274

merged 5 commits into from
Sep 22, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Jul 20, 2024 •
edited
Loading

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from secustor July 20, 2024 17:02
@rarkins rarkins enabled auto-merge July 20, 2024 17:02
@secustor
Copy link
Collaborator

needs linting fix

secustor
secustor reviewed Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs eslint fix.

viceice
viceice reviewed Aug 26, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot logging, shouldn't we move some to trace?

@rarkins
Copy link
Collaborator Author

rarkins commented Sep 22, 2024

@viceice I found these useful/necessary for debugging .npmrc problems from logs

@rarkins rarkins requested review from secustor and viceice September 22, 2024 07:41
@rarkins rarkins added this pull request to the merge queue Sep 22, 2024
Merged via the queue into main with commit b0a0a71 Sep 22, 2024
38 checks passed
@rarkins rarkins deleted the chore/log-npmrc-credentials branch September 22, 2024 08:50
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.93.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor Awaiting requested review from secustor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rarkins @secustor @renovate-release @viceice