Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging)!: drop logFile and logFileLevel #29104

Merged
merged 6 commits into from
May 17, 2024
Merged

feat(logging)!: drop logFile and logFileLevel #29104

merged 6 commits into from
May 17, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 15, 2024 •
edited
Loading

Changes

  • Drop logFile and logFileLevel

Context

Closes: #14705

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh requested a review from viceice May 15, 2024 16:52
viceice
viceice reviewed May 16, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

HonkingGoose
HonkingGoose reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you got all references to the things you're removing?

The Jest test description is good now. 😄

As usual, I'll let a maintainer do the full review.

@RahulGautamSingh
Copy link
Collaborator Author

Are you sure you got all references to the things you're removing?

Yes. 🤗

@rarkins rarkins changed the title feat(logging): drop logFile and logFileLevel feat(logging)!: drop logFile and logFileLevel May 17, 2024
@rarkins rarkins merged commit e79e78e into renovatebot:v38 May 17, 2024
34 checks passed
rarkins pushed a commit that referenced this pull request May 19, 2024
@RahulGautamSingh @HonkingGoose @rarkins
feat(logging)!: drop logFile and logFileLevel (#29104)
a7dc64f 
Co-authored-by: HonkingGoose <[email protected]>
rarkins pushed a commit that referenced this pull request May 31, 2024
@RahulGautamSingh @HonkingGoose @rarkins
feat(logging)!: drop logFile and logFileLevel (#29104)
f97852a 
Co-authored-by: HonkingGoose <[email protected]>
rarkins pushed a commit that referenced this pull request Jun 9, 2024
@RahulGautamSingh @HonkingGoose @rarkins
feat(logging)!: drop logFile and logFileLevel (#29104)
b3e86d9 
Co-authored-by: HonkingGoose <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@HonkingGoose HonkingGoose HonkingGoose requested changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RahulGautamSingh @viceice @rarkins @HonkingGoose