-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/pip-compile): Handle some edge-cases with -r dependencies #28208
Merged
rarkins
merged 4 commits into
renovatebot:main
from
mbudnek:pip-compile/dash-r-multiple-files
Apr 16, 2024
Merged
feat(manager/pip-compile): Handle some edge-cases with -r dependencies #28208
rarkins
merged 4 commits into
renovatebot:main
from
mbudnek:pip-compile/dash-r-multiple-files
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds handling for two edge-cases I missed in my previous PR to support -r dependencies: 1. A -r dependency on a multi-input lock file 2. An input file with multiple transitive -r dependencies on the same input file.
not7cd
reviewed
Apr 3, 2024
not7cd
approved these changes
Apr 3, 2024
viceice
reviewed
Apr 9, 2024
viceice
reviewed
Apr 11, 2024
viceice
reviewed
Apr 11, 2024
viceice
approved these changes
Apr 11, 2024
not7cd
approved these changes
Apr 15, 2024
🎉 This PR is included in version 37.301.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds handling for two edge-cases I missed in #28052:
CC @not7cd
Context
#28050
#28052 (specifically #28052 (comment))
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: