-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/pip-compile): Support -r dependencies between files #28052
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a95fb4c
feat(manager/pip-compile): Support -r dependencies between files
mbudnek d4a0501
Pre-compute a Map of lockFile->source to simplify lookup
mbudnek 3f421ac
Refactor to unify warning between paths
mbudnek e2e7c23
Remove redundant if not has then set
mbudnek f6126bf
Push extra lock files into existing array instead of building a new one
mbudnek a449732
Address review comments and fix a but with transitive dependencies
mbudnek 9c63dfd
Use the spread operator instead of Array.splice()
mbudnek c93ff1e
Remove unnecessary !
mbudnek b138577
Remove unnecessary !
mbudnek d8d1950
Update tests based on review feedback
mbudnek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if a lock file is duplicated across package files before this operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I suppose that could cause a problem with something like this
In that case
a.in
'slockFiles
would be["a.txt", "b.txt", "d.txt", "c.txt", "d.txt"]
and Renovate would end up runningWhere the first instance of
pip-compile d.in
would likely fail sinceb.txt
andc.txt
could ask for different versions of a newly-updated package.I'll look into fixing that on Monday.