Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasource): Add python-version datasource #27583

Merged
merged 45 commits into from
May 16, 2024
Merged

feat(datasource): Add python-version datasource #27583

merged 45 commits into from
May 16, 2024

Conversation

not7cd
Copy link
Contributor

@not7cd not7cd commented Feb 27, 2024 •
edited
Loading

Changes

Adds Python releases as Datasource.

Context

#27581

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@not7cd not7cd requested a review from viceice February 27, 2024 22:16
viceice
viceice reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Reduce fixture size, we don't need all existing versions.
  2. Fix failing tests

@rarkins this datasource seems pretty request hungry. 🤔

lib/modules/datasource/python-version/index.spec.ts Show resolved Hide resolved
lib/modules/datasource/python-version/index.spec.ts Show resolved Hide resolved
lib/modules/datasource/python-version/index.ts Outdated Show resolved Hide resolved
@not7cd not7cd requested a review from viceice March 29, 2024 17:18
viceice
viceice reviewed Mar 29, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still waiting on a comment from @rarkins

lib/modules/datasource/python-version/__fixtures__/release.json Show resolved Hide resolved
lib/modules/datasource/python-version/index.ts Outdated Show resolved Hide resolved
@not7cd
Copy link
Contributor Author

not7cd commented Mar 29, 2024

re: request hungry

This is data source is cached. And I see 3 requests if Python version is detected:

  • python.org for all versions
  • endoflife.date for EOL status
  • github releases for prebuilt versions

I don't see any way around it. No data source has all the data. Maybe python.org could be dropped in favour of using only containerbase/python, but this is the source of truth.

not7cd added 2 commits March 29, 2024 23:06
@not7cd
Reduce fixture even more
2984a0f 
Removed most of the version so only Python 3 is checked.

We also filter against every case of pre-release in deperecated and supported versions
@not7cd
never undefined
377e7f3
@not7cd not7cd requested a review from viceice March 29, 2024 22:07
@not7cd not7cd requested a review from HonkingGoose April 18, 2024 23:23
@not7cd not7cd requested a review from HonkingGoose April 19, 2024 19:12
@not7cd not7cd requested a review from HonkingGoose April 20, 2024 10:42
HonkingGoose
HonkingGoose approved these changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look okay to me. I'll let a maintainer check for technical accuracy.

@viceice
Copy link
Member

viceice commented Apr 21, 2024

The docs look okay to me. I'll let a maintainer check for technical accuracy.

can you please create an issue to validate relative links with docs tests?

@HonkingGoose HonkingGoose mentioned this pull request Apr 21, 2024
Closed
@not7cd
Copy link
Contributor Author

not7cd commented May 2, 2024

Is there anything blocking release of this data source?

@HonkingGoose
Copy link
Collaborator

I think we're good to go.

@not7cd not7cd requested a review from viceice May 9, 2024 09:02
@viceice viceice requested review from rarkins and secustor May 16, 2024 09:08
@rarkins rarkins added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@rarkins rarkins enabled auto-merge May 16, 2024 09:56
@rarkins rarkins added this pull request to the merge queue May 16, 2024
Merged via the queue into renovatebot:main with commit c8aacc4 May 16, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.366.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

@secustor secustor Awaiting requested review from secustor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@not7cd @viceice @HonkingGoose @renovate-release @rarkins