-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow security updates of lock files for unconstrained dependencies #27331
Merged
viceice
merged 8 commits into
renovatebot:main
from
not7cd:fix/pip-compile-update-unconstrained
Feb 22, 2024
Merged
fix: Allow security updates of lock files for unconstrained dependencies #27331
viceice
merged 8 commits into
renovatebot:main
from
not7cd:fix/pip-compile-update-unconstrained
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
viceice
reviewed
Feb 16, 2024
Moved to feature renovatebot#27353
Something unrelated broke in tests after my addition |
viceice
reviewed
Feb 17, 2024
viceice
approved these changes
Feb 22, 2024
🎉 This PR is included in version 37.206.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allow updates through
update-lockfile
for dependencies that don't have set current version, and have only locked version. More holistic fix would include setting>=*fixed version*
for unconstrained deps ifrangeStrategy='bump'
Context
Deps with only locked version are a consequence of unconstrained dependencies.
Minimal reproduction repo (already tested with this fix): https://github.com/icetek-lab/renovate-bug4
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: