Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Override Brotli compress default options #26648

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented Jan 15, 2024

Changes

  • BROTLI_PARAM_QUALITY could be a number from 0 to 11. By default, it's 11, and it's slow. I've found 8 is an optimal value which does decent compression and performs well enough.
  • According to docs BROTLI_MODE_TEXT is adjusted for UTF-8 text, so let's set it as well.

These changes will significantly speed up the compressing phase, while decompressing speed remains the same.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov
Copy link
Collaborator Author

Cold start

Backend Count (r/w) Total Ms (r/w) Avg Ms (r/w) Median ms (r/w) Max Ms (r/w)
Redis (old) 660/641 1106/10422 2/16 0/4 136/1238
Redis (new) 660/641 1363/2862 2/4 0/2 71/296
File (old) 660/641 508/12657 1/20 0/6 20/1244
File (new) 660/641 386/3350 1/5 0/3 29/297

Warm Start

Backend Count (r/w) Total Ms (r/w) Avg Ms (r/w) Median ms (r/w) Max Ms (r/w)
Redis (old) 499/194 8797/984 18/5 1/2 392/217
Redis (new) 499/194 8832/199 18/1 1/1 390/9
File (old) 499/194 9360/1179 19/6 1/3 389/218
File (new) 499/194 9260/425 19/2 1/2 375/10

@zharinov zharinov requested a review from viceice January 15, 2024 23:17
@rarkins rarkins added this pull request to the merge queue Jan 16, 2024
Merged via the queue into renovatebot:main with commit 5506224 Jan 16, 2024
36 checks passed
@rarkins rarkins deleted the fix/compress-perf branch January 16, 2024 08:41
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.135.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants