Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(github): improve example endpoint #26574

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

paul-hammant
Copy link
Contributor

Readers might miss the clue that they should change the URL for their on-premises or in-cloud instance of GHE

--> CLA signed, contributing guide read.

Changes

clearer documentation

Context

enterprise.com isn't a domain is classically used in snippets of example code. example.com is.

Documentation (please check one with an [x])

  • [✓] I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
  • [✓] No code was changed

Readers might miss the clue that they should change the URL for their on-premises or in-cloud instance of GHE
@rarkins rarkins enabled auto-merge January 10, 2024 11:41
@rarkins rarkins changed the title Update readme.md to be clearer docs(github): improve example endpoint Jan 10, 2024
@rarkins rarkins added this pull request to the merge queue Jan 10, 2024
@paul-hammant
Copy link
Contributor Author

Gotta love a 20 minute turnaround :)

Merged via the queue into renovatebot:main with commit 9ce2d94 Jan 10, 2024
34 checks passed
@rarkins
Copy link
Collaborator

rarkins commented Jan 10, 2024

Thank you for contributing!

@rarkins
Copy link
Collaborator

rarkins commented Jan 10, 2024

Contributions which make docs better for future users are a kind and thoughtful act

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.128.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

firke pushed a commit to firke/renovate that referenced this pull request Jan 12, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants