Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helmv3): add --force-update when adding a repo #26512

Merged

Conversation

gaelgatelement
Copy link
Contributor

Changes

We add --force-update to overwrite any existing repo with the same name.

Context

When using renovate to update helm lock files in a monorepo, we encounter the following error when a helm chart is present in multiple Chart.yaml :

The artifact failure details are included below:

Command failed: helm repo add <name> <url>
Error: repository name (<name>) already exists, please specify a different name

Using --force-update works around this behaviour by overwriting any existing repo with the same name.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2024

CLA assistant check
All committers have signed the CLA.

@gaelgatelement gaelgatelement changed the title helm v3: add --force-update when adding a repo fix(helmv3): add --force-update when adding a repo Jan 5, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA, otherwise LGTM

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs cla signing

@gaelgatelement
Copy link
Contributor Author

I signed the CLA.

@viceice viceice added this pull request to the merge queue Jan 8, 2024
Merged via the queue into renovatebot:main with commit 085ef7c Jan 8, 2024
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.126.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

firke pushed a commit to firke/renovate that referenced this pull request Jan 12, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants