Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terragrunt): add support for tfr prefix #26209

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

ps-occrp
Copy link
Contributor

@ps-occrp ps-occrp commented Dec 10, 2023

Changes

Adds support for tfr source

Context

Terragrunt manager does not support tfr source which has existed in Terragrunt for a few years, this PR adds support for that.

Related to #22890

Documentation (please check one with an [x])

  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or

@rarkins rarkins changed the title feat: add support for tfr prefix feat(terragrunt): add support for tfr prefix Dec 10, 2023
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add or update a test

lib/modules/manager/terragrunt/modules.ts Outdated Show resolved Hide resolved
@ps-occrp
Copy link
Contributor Author

Please add or update a test

Can you point me to place where I can see test for some of the other part of the code? tried to find it myself didn't find it.

@ps-occrp ps-occrp force-pushed the add-support-for-tfr-prefix branch from 11a270c to 7f91fcd Compare December 11, 2023 10:07
@rarkins
Copy link
Collaborator

rarkins commented Dec 11, 2023

image

@ps-occrp ps-occrp requested a review from rarkins December 11, 2023 15:06
@ps-occrp ps-occrp requested a review from viceice December 12, 2023 17:24
@viceice
Copy link
Member

viceice commented Dec 12, 2023

please create a reproduction and run this against it. we need to validate your slitting is working as expected.

@ps-occrp
Copy link
Contributor Author

please create a reproduction and run this against it. we need to validate your slitting is working as expected.

I have created reproduction repo, how can I use my renovate branch with this reproduction repo?

Here is my repo https://github.com/ps-occrp/tfr-renovate

@ps-occrp
Copy link
Contributor Author

please create a reproduction and run this against it. we need to validate your slitting is working as expected.

Thanks for suggesting this, in reproduction repo I found some missing things, I ended up refactoring it using a regex.

@ps-occrp ps-occrp requested a review from viceice December 12, 2023 21:58
@ps-occrp
Copy link
Contributor Author

@rarkins @viceice can you merge this PR?

@rarkins rarkins added this pull request to the merge queue Dec 14, 2023
Merged via the queue into renovatebot:main with commit 1521e67 Dec 14, 2023
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.95.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

hersentino pushed a commit to hiventive/renovate that referenced this pull request Jan 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants