fix(github): Massage links to issues, pulls or discussions

[zharinov]

Changes:

While replacing for all GitHub links turned to be painful, the more restricted subset (discussions, issues and pulls) should protect us from spamming mentioned repositories.

Context:

Closes #10902
Created instead of #11133

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[HonkingGoose]

Seems there's a problem with the Jest snapshots?

[zharinov]

Ah, thanks a lot. I've enfored preserving of whilte spaces code, which broke old snapshot.

[HonkingGoose]

Ah, thanks a lot. I've enfored preserving of whilte spaces code, which broke old snapshot.

You're welcome. By the way you also missed clicking the checkboxes in the PR body text. 😉

[rarkins]

What about users? if there's a link to https://github.com/rarkins in a PR body, will I get notified?

What I'm worried about is: can this make our linkback spam worse by accident?

@zharinov I've added your user URL to a PR in https://github.com/renovate-tests/pip-compile-1 - did you get a notification?

[zharinov]

What about users? if there's a link to https://github.com/rarkins in a PR body, will I get notified?
@zharinov I've added your user URL to a PR in https://github.com/renovate-tests/pip-compile-1 - did you get a notification?

Seems like it works only by using @ character. I received nothing via email or GitHub news feed.

What I'm worried about is: can this make our linkback spam worse by accident?

It shouldn't: it's just one more step added to our existing checks and replacements.
Though, we don't emit and return result from remarkjs anymore (i.e. parse -> tree replace -> emit).
Instead, I've walked the entire parsed tree, detected things that has to be changed, and then performed replacements based on offsets (i.e. parse -> detect -> string replace).
This should minimize PR edits once fix is released.

[viceice]

Beside types LGTM

[renovate-release]

🎉 This PR is included in version 25.72.3 🎉

The release is available on:

• GitHub release
• 25.72.3

Your semantic-release bot 📦🚀