refactor: remove templating from FATAL logs

renovatebot · Jan 9, 2025 · ebf5534 · ebf5534
1 parent 47d7b14
commit ebf5534
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/lib/logger/utils.ts b/lib/logger/utils.ts
@@ -317,7 +317,10 @@ export function validateLogLevel(
       },
     ],
   });
-  logger.fatal(`${logLevelToCheck} is not a valid log level. terminating...`);
+  logger.fatal(
+    { logLevel: logLevelToCheck },
+    'Invalid log level. terminating...',
+  );
   process.exit(1);
 }
 

diff --git a/lib/workers/global/config/parse/file.ts b/lib/workers/global/config/parse/file.ts
@@ -59,7 +59,7 @@ export async function getConfig(env: NodeJS.ProcessEnv): Promise<AllConfig> {
     config = await getParsedContent(configFile);
   } catch (err) {
     if (err instanceof SyntaxError || err instanceof TypeError) {
-      logger.fatal(`Could not parse config file \n ${err.stack!}`);
+      logger.fatal({ error: err.stack }, 'Could not parse config file');
       process.exit(1);
     } else if (err instanceof ReferenceError) {
       logger.fatal(

diff --git a/lib/workers/global/index.ts b/lib/workers/global/index.ts
@@ -221,9 +221,9 @@ export async function start(): Promise<number> {
     await exportStats(config);
   } catch (err) /* istanbul ignore next */ {
     if (err.message.startsWith('Init: ')) {
-      logger.fatal(err.message.substring(6));
+      logger.fatal({ errorMessage: err.message.substring(6) }, 'Fatal error');
     } else {
-      logger.fatal({ err }, `Fatal error: ${String(err.message)}`);
+      logger.fatal({ err, errorMessage: err.message }, 'Fatal error');
     }
     if (!config!) {
       // return early if we can't parse config options