Address review comments

renovatebot · Dec 29, 2024 · b93ee7a · b93ee7a
1 parent 74137a8
commit b93ee7a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/modules/platform/gerrit/client.ts b/lib/modules/platform/gerrit/client.ts
@@ -2,6 +2,7 @@ import { REPOSITORY_ARCHIVED } from '../../../constants/error-messages';
 import { logger } from '../../../logger';
 import { GerritHttp } from '../../../util/http/gerrit';
 import { regEx } from '../../../util/regex';
+import { getQueryString } from '../../../util/url';
 import type {
   GerritAccountInfo,
   GerritBranchInfo,
@@ -77,8 +78,9 @@ class GerritClient {
     extraOptions?: string[],
   ): Promise<GerritChange> {
     const options = [...this.requestDetails, ...(extraOptions ?? [])];
+    const queryString = getQueryString({ o: options });
     const changes = await this.gerritHttp.getJson<GerritChange>(
-      `a/changes/${changeNumber}?` + options.map((det) => `o=${det}`).join('&'),
+      `a/changes/${changeNumber}?${queryString}`,
     );
     return changes.body;
   }
@@ -203,7 +205,7 @@ class GerritClient {
     const reviewLabel = change?.labels?.['Code-Review'];
     return (
       reviewLabel === undefined ||
-      Boolean(reviewLabel.all?.some((label) => label.value === 2))
+      reviewLabel.all?.some((label) => label.value === 2) === true
     );
   }
 

diff --git a/lib/workers/repository/update/pr/automerge.spec.ts b/lib/workers/repository/update/pr/automerge.spec.ts
@@ -128,7 +128,6 @@ describe('workers/repository/update/pr/automerge', () => {
       config.autoApprove = true;
       config.automerge = true;
       config.pruneBranchAfterAutomerge = true;
-      platform.approvePrForAutomerge.mockResolvedValueOnce();
       platform.getBranchStatus.mockResolvedValueOnce('green');
       platform.mergePr.mockResolvedValueOnce(true);
       const res = await prAutomerge.checkAutoMerge(pr, config);