use app default event loop for websocket calls #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For websocket calls, instead of creating a new event loop, it's better using the default one. This allows other IO events can be attached to the same event loop and act on each other accordingly. For example (pseudo code),
Besides, it is recommended by ReactPHP. The
create
method has been deprecated: https://github.com/reactphp/event-loop/blob/1.x/src/Factory.php#L13-L34