Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transfer fees to treasury #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devwckd
Copy link
Contributor

@devwckd devwckd commented Feb 3, 2025

Closes CHAIN-60

Copy link

linear bot commented Feb 3, 2025

Copy link
Member

@functor-flow functor-flow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to refactor the logic completely so there is no burn and mint in the first place

The whole process would be:

Submit proposal / application -> goes straight to treasury (transfer)
Not accepted -> keep in treasury
Accepted -> send from treasury back to payer

so you will transfer from payer to the treasury

something like

   <pallet_balances::Pallet<T>>::transfer(payer, treasury, value)

@devwckd devwckd force-pushed the feat/send-fees-to-treasury branch from 899746a to effdcf4 Compare February 11, 2025 18:12
Copy link
Collaborator

@saiintbrisson saiintbrisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few dbgs in the code, other than that, lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants