rm_netxduo_ether receive path fixes regarding netx interface index and pointer #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface access When rm_netxduo_ether is not first interface registered with netxduo stack, indexing using p_cfg->channel won't work.
If it is kept uninitialized (NULL), netxduo stack initializes it to &nx_ip_interface[0], which is correct only if rm_netxduo_ether is registered as first interface of given IP stack.
jritchey-renesas
suggested changes
Oct 7, 2024
There was a problem hiding this comment.
I agree, this is a bug in the existing driver.
Could you also apply this change to lines 788, and 833? The correct interface index needs to be provided to _nx_ip_driver_link_status_event.
/* Notify NetX that the link is up. */
p_netxduo_ether_instance->p_ctrl->p_interface->nx_interface_link_up = NX_TRUE;
_nx_ip_driver_link_status_event(p_netxduo_ether_instance->p_ctrl->p_ip,
p_netxduo_ether_instance->p_ctrl->p_interface->nx_interface_index); /* Notify NetX that the link is down. */
p_netxduo_ether_instance->p_ctrl->p_interface->nx_interface_link_up = NX_FALSE;
_nx_ip_driver_link_status_event(p_netxduo_ether_instance->p_ctrl->p_ip,
p_netxduo_ether_instance->p_ctrl->p_interface->nx_interface_index);
jritchey-renesas
added
bug
| @@ -332,7 +332,7 @@ void rm_netxduo_ether (NX_IP_DRIVER * driver_req_ptr, rm_netxduo_ether_instance_ | |||
| { | |||
| /* Return the link status in the supplied return pointer. */ | |||
| *(driver_req_ptr->nx_ip_driver_return_ptr) = | |||
| driver_req_ptr->nx_ip_driver_ptr->nx_ip_interface[p_ether_instance->p_cfg->channel].nx_interface_link_up; | |||
| driver_req_ptr->nx_ip_driver_ptr->nx_ip_interface[interface_ptr->nx_interface_index].nx_interface_link_up; | |||
There was a problem hiding this comment.
We can access interface_ptr directly here.
*(driver_req_ptr->nx_ip_driver_return_ptr) = interface_ptr->nx_interface_link_up;
|
This PR is tracked internally by FSPRA-3840. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fixes, rm_netxduo_ether is only usable if it is the primary interface of given netxduo NX_IP stack.
But that's not always the case!