vsp2driver: Support to convert full-range YCbCr buffers #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vsp2driver is supporting BT.601 and BT.709 colorspaces. Specifications of both standards mentions that default quantization for YCbCr buffers limited range, and it is full range for RGB buffers. Nevertheless vsp2 device supports to correctly convert full range YCbCr buffers to RGB. We need to set clrcng of vsp_src_t data structure to 0x01 to specify our buffers as full range. v4l2_pix_format_mplane data structure has the necessary information about quantization. We need to use this information to correctly set quantization for YCbCr to RGB conversion. Signed-off-by: Emre Ucan <[email protected]> Signed-off-by: Steve Longerbeam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vsp2driver is supporting BT.601 and BT.709 colorspaces.
Specifications of both standards mentions that
default quantization for YCbCr buffers limited range, and
it is full range for RGB buffers.
Nevertheless vsp2 device supports to correctly convert
full range YCbCr buffers to RGB. We need to set clrcng
of vsp_src_t data structure to 0x01 to specify our buffers
as full range.
v4l2_pix_format_mplane data structure has the necessary
information about quantization. We need to use this
information to correctly set quantization for YCbCr to
RGB conversion.
Signed-off-by: Emre Ucan [email protected]
Signed-off-by: Steve Longerbeam [email protected]