Router accepts a stream response from ViewEngine #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this doesn't work in Node v0.8.x. As the stream API changed in v0.10 it seems reasonable to only support the streaming functionality in v0.10+. I will modify it to work in an pre v0.10 environment. |
|
Oooo this is a really cool change set! Thanks for submitting it (sorry i haven't had time to check into it yet). I'm releasing 1.0.2 right now, let me do that then i'll check out this PR a bit more. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support streaming responses from the server by allowing a custom ViewEngine to return a stream rather than an html string.