Feature/lean external arith shifts #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Nat.sub
We're using function composition, which may or may not be okay.
|
Lean should have a |
|
Only for |
jprider63
reviewed
Feb 13, 2025
|
|
||
| def shiftl (a : Int) (n : Int) : Int := | ||
| match n with | ||
| | Int.ofNat n => Sail.Nat.iterate (fun x => x * 2) n a |
There was a problem hiding this comment.
Were you still planning on using shift operators for these? We're going to merge, but maybe you can open another PR with those updates.
|
Merge this after #970. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lean4 support for the following functions in
arith.sail:_shl8_shl32_shl1_shl_int_shr32_shr_int