Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check start_time too #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

eriksulymosi
Copy link

/api/v1/users/subscriptions
could return future subscriptions

@rootpd
Copy link
Member

rootpd commented Mar 18, 2023

The API however is meant to return future subscriptions, that's by design.

When a client requests list of subscriptions, it makes sense to return all available subscriptions, even those which haven't started yet. The base use case is giving user the information when his/hers subscription ends. Otherwise the user could receive incorrect information that the subscription is about to end even when it isn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants