-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change post processing example #1465
base: main
Are you sure you want to change the base?
Conversation
It now displays both how to match `getByteFrequencyData()` and `getFloatFrequencyData()`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Seems like a good change, can we briefly explain when one should use the one over another? Is this for visualizing voice vs. music? |
Both are for making frequency visualizations (usually "bars"). This will just make Remotion compatible with all the WebAudio tutorials on the internet (most use getByteFrequencyData). I'm guessing the person who asked about The missing API are |
Before we returned one array that the example claims makes the visualization nicer than the default. Would it make sense to make this an additional snippet instead? |
Hmm, if the purpose of the page is to just provide a copy-paste snippet then we should remove the W3C-related info and move it to another page. The PR was more for making If that sounds good I'll edit the PR for a suggested change. A note on "good looking" frequency visualizations. A pleasing looking frequency visualization will do two main things:
Both of these are logically unintuitive, but incredibly intuitive to our hearing and vision since we experience loudness and frequencies logarithmically, but more often like to see a visual representation that looks linear. It's one of those things that just "feels a little off" unless presented correctly. Presenting it well requires a high enough frequency resolution so we can sample the right things. A FFT window of 2048 (the default in But... if displaying a frequency spectrum that feels like it follows the music isn't important then all of this doesn't really matter. 😄 |
bb1b2d6
to
ff2e2b6
Compare
It now displays both how to match
getByteFrequencyData()
andgetFloatFrequencyData()