chore(json-logic): Add skipped broken unit test for missing json-logic reduce support
#98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollyd
reviewed
Dec 2, 2024
sandrina-p
reviewed
Dec 2, 2024
brennj
force-pushed
the
ensure-reduce-is-supported
branch
from
f544251 to
d0e402b
Compare
brennj
changed the title
reduce for json logic was not workingreduce support
|
rebased with |
sandrina-p
reviewed
Mar 6, 2025
sandrina-p
force-pushed
the
ensure-reduce-is-supported
branch
from
d0e402b to
67d98ec
Compare
sandrina-p
approved these changes
Mar 6, 2025
sandrina-p
changed the title
reduce supportreduce support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug brought up internally when trying to create a schema similar to the test case. This is because of a false assumption on my side where I didn't need to account for "temp variables" that are indeed supported in json logic for cases like
reduce.