fix: reduce for json logic was not working
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollyd
reviewed
Dec 2, 2024
| @@ -399,6 +399,7 @@ function checkRuleIntegrity( | |||
| subRule.map((item) => { | |||
| const isVar = item !== null && typeof item === 'object' && Object.hasOwn(item, 'var'); | |||
| if (isVar) { | |||
| if (Array.isArray(item.var)) return; // Is an accumlator for reduce and can't be checked. | |||
There was a problem hiding this comment.
Suggestion
Just wondering if there could ever be an array path which we would want to validate? 🤔
Might be safer to be less permissive: const isReducerVar = operator === 'reduce' && Array.isArray(item.var)
This also makes the code more explicit so we don't need code comments. 🙂
sandrina-p
reviewed
Dec 2, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@remoteoss/json-schema-form", | |||
| "version": "0.11.8-beta.0", | |||
| "version": "0.11.9-dev.20241127210659", | |||
There was a problem hiding this comment.
Hi! Forgive me, I can't review this, I has been wrapping up my work before going on vacation for the next two weeks. I'll defer to @ollyd here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug brought up internally when trying to create a schema similar to the test case. This is because of a false assumption on my side where I didn't need to account for "temp variables" that are indeed supported in json logic for cases like
reduce.