feat: allow formatted date cells to be empty (#2)

* feat: allow formatted date cells to be empty * add oracle test * remove dbg * Update test/oracle_test.exs
remoteoss · Jun 11, 2024 · da3a796 · da3a796
1 parent 4d06bde
commit da3a796
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/lib/elixlsx/util.ex b/lib/elixlsx/util.ex
@@ -231,6 +231,10 @@ defmodule Elixlsx.Util do
     {:formula, value}
   end
 
+  @spec to_excel_datetime(binary() | nil) :: binary()
+  def to_excel_datetime(""), do: ""
+  def to_excel_datetime(nil), do: ""
+
   @doc ~S"""
   Replace_all(input, [{search, replace}]).
 

diff --git a/test/oracle_test.exs b/test/oracle_test.exs
@@ -44,4 +44,14 @@ defmodule OracleTest do
 
     assert check(bin)
   end
+
+  test "empty date cells" do
+    s = Sheet.with_name("1") |> Sheet.set_cell("A4", "", yyyymmdd: true)
+
+    wk = %Workbook{} |> Workbook.append_sheet(s)
+
+    assert {:ok, {_, bin}} = Elixlsx.write_to_memory(wk, "")
+
+    assert check(bin)
+  end
 end