Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(future/vite): fix grammar #9036

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

dcramer
Copy link
Contributor

@dcramer dcramer commented Mar 12, 2024

Language here was bothering me.

Feel free to close if you disagree!

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: fa45937

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 12, 2024

Hi @dcramer,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@machour
Copy link
Collaborator

machour commented Mar 12, 2024

Thank you @dcramer !
Could you sign the CLA to get this merged in?

@machour machour changed the title Correct language docs(future/vite): Remove extra comma Mar 12, 2024
@dcramer
Copy link
Contributor Author

dcramer commented Mar 12, 2024

Thank you @dcramer ! Could you sign the CLA to get this merged in?

Do I make a separate PR to sign it I assume?

Update: Saw it referenced this branch so just added in this PR.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Mar 12, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title docs(future/vite): Remove extra comma docs(future/vite): fix grammar Mar 13, 2024
@MichaelDeBoey MichaelDeBoey merged commit 0007a63 into remix-run:main Mar 13, 2024
1 check passed
@dcramer dcramer deleted the patch-1 branch March 15, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants