Pin Playwright to Node 20.5.1 to fix hanging tests #9000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary fix to unblock CI.
Playwright tests are hanging in CI when running against Node 20, currently 20.11.1. I've narrowed it down to this line that's hanging indefinitely:
remix/integration/helpers/create-fixture.ts
Line 94 in cc4dcf1
If I try to import the server build file directly within Node, everything works fine. I tried commenting out the contents of the server build to further narrow it down and found that it only hangs when importing Remix packages. After narrowing this down, I've been able to reproduce the same issue simply by importing a Remix package within a Playwright test file.
I'm not sure why this is happening since the move to pnpm, but this import statement doesn't hang in Node 20.5.1, so I'm updating our workflows to use this version until we can properly fix it.