Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Playwright to Node 20.5.1 to fix hanging tests #9000

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Mar 7, 2024

This PR is a temporary fix to unblock CI.

Playwright tests are hanging in CI when running against Node 20, currently 20.11.1. I've narrowed it down to this line that's hanging indefinitely:

let app: ServerBuild = await import(buildPath);

If I try to import the server build file directly within Node, everything works fine. I tried commenting out the contents of the server build to further narrow it down and found that it only hangs when importing Remix packages. After narrowing this down, I've been able to reproduce the same issue simply by importing a Remix package within a Playwright test file.

I'm not sure why this is happening since the move to pnpm, but this import statement doesn't hang in Node 20.5.1, so I'm updating our workflows to use this version until we can properly fix it.

Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: e9bb912

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish changed the title Roll back Playwright Node 20 version to fix hanging tests Pin Playwright to Node 20.5.1 to fix hanging tests Mar 7, 2024
@markdalgleish markdalgleish merged commit f48733e into dev Mar 7, 2024
5 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/ci-node-20-5-1 branch March 7, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant