Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ssr.noExternal to the SPA template vite config #8928

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Add ssr.noExternal to the SPA template vite config #8928

merged 2 commits into from
Feb 29, 2024

Conversation

brophdawg11
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d03c2b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 force-pushed the brophdawg11/spa-ssr-no-external branch from 780c462 to 5021d5c Compare February 28, 2024 15:31
markdalgleish
markdalgleish approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor wording suggestions, but this looks great 👍

@brophdawg11 brophdawg11 mentioned this pull request Feb 29, 2024
Closed
@brophdawg11 brophdawg11 merged commit 946afc5 into main Feb 29, 2024
5 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/spa-ssr-no-external branch February 29, 2024 15:31
IgnusG pushed a commit to IgnusG/remix that referenced this pull request Mar 4, 2024
@brophdawg11 @markdalgleish @IgnusG
Add ssr.noExternal to the SPA template vite config (remix-run#8928)
7d40eb4 
Co-authored-by: Mark Dalgleish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdalgleish markdalgleish markdalgleish approved these changes

Assignees
No one assigned
Labels
CLA Signed docs template:spa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brophdawg11 @markdalgleish