-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type check .server
/.client
dirs in Vite templates
#8899
Type check .server
/.client
dirs in Vite templates
#8899
Conversation
|
Hi @wahyubucil, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm keen to get this in with a couple of tweaks:
- Include tsx files too, as you mentioned
- Add client directories too for completeness:
**/.client/**/*.ts
and**/.client/**/*.tsx
The issue with the "node" type is a separate one, would you mind opening another PR for that?
Thanks @markdalgleish for reviewing my PR!
Ok, will do that. |
It's done! For this:
It's on #8900 |
.server
modules.server
/.client
dirs to tsconfig in Vite templates
.server
/.client
dirs to tsconfig in Vite templates.server
/.client
dirs in Vite templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, and thanks for the PR!
Closes: #8898
Testing Strategy:
I edited the provided StackBlitz link on the issue with the new
tsconfig.json
on this PR.Note:
node
type, I'm not sure if we still need it or not. If we need it, then I will put it back and install the@types/node
on thedevDependencies
.include
field, I only added.ts
files to detect, let me know if I also need to include.tsx
files.