Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(remix-dev/vite): simplify config resolution #8554

Merged

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Jan 18, 2024

Our Vite plugin config resolution logic had gotten a bit out of hand so I've taken a pass at flattening everything out and avoiding unnecessary object spreads so it's really clear what's going on.

I've also renamed the adapter types from Adapter / AdapterOverrides / AdapterWithoutOverrides to AdapterConfig / AdapterRemixConfigOverrides / Adapter. This makes the code much clearer now and eliminates the need for translating names, e.g. we don't need to write adapter: adapterWithoutOverrides on the resolved Remix config object and instead can just pass through the resolved adapter value.

Copy link

changeset-bot bot commented Jan 18, 2024

⚠️ No Changeset found

Latest commit: 18cb0d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit 2c38565 into dev Jan 18, 2024
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/refactor-vite-plugin-config-resolution branch January 18, 2024 21:50
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 18, 2024
Copy link
Contributor

🤖 Hello there,

We just published version 2.6.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Feb 1, 2024

🤖 Hello there,

We just published version 2.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant