refactor(remix-dev/vite): simplify config resolution #8554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Vite plugin config resolution logic had gotten a bit out of hand so I've taken a pass at flattening everything out and avoiding unnecessary object spreads so it's really clear what's going on.
I've also renamed the adapter types from
Adapter
/AdapterOverrides
/AdapterWithoutOverrides
toAdapterConfig
/AdapterRemixConfigOverrides
/Adapter
. This makes the code much clearer now and eliminates the need for translating names, e.g. we don't need to writeadapter: adapterWithoutOverrides
on the resolved Remix config object and instead can just pass through the resolvedadapter
value.