Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/vite): remove http2 pseudo headers from internal request #8049

Closed
wants to merge 2 commits into from
Closed

fix(remix-dev/vite): remove http2 pseudo headers from internal request #8049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f06ef6
fix(remix-dev/vite): remove http2 pseudo headers from request
hi-ogawa Nov 18, 2023
1d3bb13
chore: changeset
hi-ogawa Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/good-pandas-burn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Fix validation error due to http2 pseudo headers
5 changes: 5 additions & 0 deletions packages/remix-dev/vite/node/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ function createHeaders(requestHeaders) {
let headers = new Headers();

for (let [key, values] of Object.entries(requestHeaders)) {
// skip http2 pseudo headers since it would cause validation error
// in @remix-run/web-fetch's Headers polyfill
if (key.startsWith(":")) {
continue;
}
if (values) {
if (Array.isArray(values)) {
for (let value of values) {
Expand Down