Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vite): assert css-bundle removal #7985

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Nov 13, 2023

I'm still seeing usage of the css-bundle package in Remix + Vite repos in the wild. The docs suggest that removing the css-bundle package is optional, but this is leftover from when we placed more emphasis on allowing Vite-based Remix projects to be backwards compatible with the esbuild compiler. However, the docs are now written much more assertively in the direction of removing anything Vite doesn't use or support. This PR updates the css-bundle section to be more in line with the rest of the docs.

Copy link

changeset-bot bot commented Nov 13, 2023

⚠️ No Changeset found

Latest commit: 5466b24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit a68cd58 into main Nov 13, 2023
@markdalgleish markdalgleish deleted the markdalgleish/remove-css-bundle branch November 13, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant