Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): support Vite 5 #7983

Merged
merged 7 commits into from
Nov 13, 2023
Merged

fix(vite): support Vite 5 #7983

merged 7 commits into from
Nov 13, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Nov 12, 2023

Since Vite 5 is due to be released in the coming days, this PR bumps our peer dependency range to ^4.4.9 || ^5.0.0, and also updates our dev dependency to 5.0.0-beta.18 so we can be confident that we're ready for the release.

The most notable change for us is that the CJS build of Vite is deprecated and due to be removed in v6. Our use of the CJS build still works in v5 but leaving it in would mean that the consumer sees a deprecation warning in the terminal. To avoid this deprecation warning without forcing us to migrate to ESM right now, we're now dynamically importing the vite package up-front in our plugin's config hook.

Copy link

changeset-bot bot commented Nov 12, 2023

⚠️ No Changeset found

Latest commit: ab31790

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish markdalgleish merged commit f2ccdd7 into dev Nov 13, 2023
@markdalgleish markdalgleish deleted the markdalgleish/vite-5 branch November 13, 2023 19:25
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Nov 13, 2023
Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 2.3.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant