-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-dev/cli): add --debug-binding
flag
#4325
Conversation
|
@jstafman can you rebased & fix the conflict? 🙏🏼 |
0d00464
to
a6c7136
Compare
a6c7136
to
1704f35
Compare
--debug-binding
flag
Hi @jstafman! Are you still interested in getting this one merged? If so, please rebase onto latest |
@MichaelDeBoey - It looks like a lot has changed since I first created this pull request. It might be easier for me to start with the current |
The new dev server ( Since we are actively pushing towards v2 right now and will be removing the old dev server flow, might be best to try this with the new dev server and only proceed if there are issues with that. |
The new v2 dev server is now stabilized. With |
Closes: #
My preference would be to make
--debug
accept an optional value as described here: #4216 (comment). However, I was not able to figure how to make that work. I've tried making it a string instead of boolean, but it is rejected when no value is provided. I also tried creating a custom handler, with the same result. If anyone has a suggestion on how to approach that, please let me know. There is currently an open issue about this for thearg
package: vercel/arg#61 (comment).Testing Strategy:
--debug-binding
flag using a playground, including:remix dev --debug
(default)remix dev --debug --debug-binding 0:0:0:0:9229
remix dev --debug --debug-binding 0:0:0:0
remix dev --debug-binding 0:0:0:0:9229
(shouldn't load debug at all)yarn test
and all tests passed