Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle interrupted __manifest requests in lazy route discovery #10447

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Properly handle interrupted __manifest requests in lazy route discovery #10447

merged 2 commits into from
Jan 30, 2025

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jan 29, 2025 •
edited
Loading

Sibling RR PR: remix-run/react-router#12900
Closes #10397

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d9aab99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/fs-routes Patch
@remix-run/node Patch
@remix-run/route-config Patch
@remix-run/routes-option-adapter Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 mentioned this pull request Jan 29, 2025
Closed
@brophdawg11 brophdawg11 linked an issue Jan 29, 2025 that may be closed by this pull request
Navigation fails due to missing manifest (fog of war enabled) #10397
Closed
brophdawg11
brophdawg11 commented Jan 29, 2025
View reviewed changes
packages/remix-react/fog-of-war.ts
let serverPatches = (await res.json()) as AssetsManifest["routes"];
serverPatches = (await res.json()) as AssetsManifest["routes"];
} catch (e) {
if (signal?.aborted) return;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the crux of the issue. React Router doesn't patch when aborted, but we were still continuing here and patching the manifest letting the two get out of sync

@brophdawg11 brophdawg11 force-pushed the brophdawg11/fow-interruptions branch from 960ccbf to d9aab99 Compare January 29, 2025 20:38
@brophdawg11 brophdawg11 merged commit aae1aae into release-next Jan 30, 2025
7 of 9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fow-interruptions branch January 30, 2025 15:41
@github-actions github-actions bot mentioned this pull request Jan 30, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.15.3-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Jan 30, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.15.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@aaronadamsCA aaronadamsCA mentioned this pull request Feb 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigation fails due to missing manifest (fog of war enabled)
1 participant
@brophdawg11